diff options
| author | Deepa Dinamani | 2016-09-14 07:48:03 -0700 |
|---|---|---|
| committer | Al Viro | 2016-09-27 21:06:20 -0400 |
| commit | 2554c72edb81c97ae5307613dd0aee1ef8dd13ca (patch) | |
| tree | 94e032756f45ea9ced6ddabfcd77e72d7cdfa45d /fs | |
| parent | 3cd886666ff19e9796a519e16d94fc94f79c8a4c (diff) | |
fs: proc: Delete inode time initializations in proc_alloc_inode()
proc uses new_inode_pseudo() to allocate a new inode.
This in turn calls the proc_inode_alloc() callback.
But, at this point, inode is still not initialized
with the super_block pointer which only happens just
before alloc_inode() returns after the call to
inode_init_always().
Also, the inode times are initialized again after the
call to new_inode_pseudo() in proc_inode_alloc().
The assignemet in proc_alloc_inode() is redundant and
also doesn't work after the current_time() api is
changed to take struct inode* instead of
struct *super_block.
This bug was reported after current_time() was used to
assign times in proc_alloc_inode().
Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Reported-by: Fengguang Wu <fengguang.wu@intel.com> [0-day test robot]
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/proc/inode.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/proc/inode.c b/fs/proc/inode.c index c1b72388e571..ce1f1a919902 100644 --- a/fs/proc/inode.c +++ b/fs/proc/inode.c @@ -68,7 +68,6 @@ static struct inode *proc_alloc_inode(struct super_block *sb) ei->sysctl_entry = NULL; ei->ns_ops = NULL; inode = &ei->vfs_inode; - inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME; return inode; } |