diff options
| author | Uwe Kleine-König | 2021-10-12 17:39:27 +0200 |
|---|---|---|
| committer | Bartosz Golaszewski | 2021-10-13 19:52:26 +0200 |
| commit | 06de2cd788bfa3b51137e9bd471d68029ab68103 (patch) | |
| tree | 8a1042de7ffc0b9997891a17c0f1555f67145eb2 /include/linux/spi | |
| parent | aa4858eb8264358e9c18c3ad79d6ab4fdc71e0c2 (diff) | |
gpio: max730x: Make __max730x_remove() return void
An spi or i2c remove callback is only called for devices that probed
successfully. In this case this implies that __max730x_probe() set a
non-NULL driver data. So the check ts == NULL is never true. With this
check dropped, __max730x_remove() returns zero unconditionally. Make it
return void instead which makes it easier to see in the callers that
there is no error to handle.
Also the return value of i2c and spi remove callbacks is ignored anyway.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Diffstat (limited to 'include/linux/spi')
| -rw-r--r-- | include/linux/spi/max7301.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/spi/max7301.h b/include/linux/spi/max7301.h index 21449067aedb..e392c53758bc 100644 --- a/include/linux/spi/max7301.h +++ b/include/linux/spi/max7301.h @@ -31,6 +31,6 @@ struct max7301_platform_data { u32 input_pullup_active; }; -extern int __max730x_remove(struct device *dev); +extern void __max730x_remove(struct device *dev); extern int __max730x_probe(struct max7301 *ts); #endif |