diff options
| author | Gerald Schaefer | 2022-10-27 16:19:38 +0200 |
|---|---|---|
| committer | Alexander Gordeev | 2022-11-16 11:39:11 +0100 |
| commit | a41a11b4009580edb6e2b4c76e5e2ee303f87157 (patch) | |
| tree | ce68fae9954386e4727b35ae45ddc8e12b3cbeea /include/linux | |
| parent | 30d17fac6aaedb40d111bb159f4b35525637ea78 (diff) | |
s390/dcssblk: fix deadlock when adding a DCSS
After the rework from commit 1ebe2e5f9d68 ("block: remove
GENHD_FL_EXT_DEVT"), when calling device_add_disk(), dcssblk will end up
in disk_scan_partitions(), and not break out early w/o GENHD_FL_NO_PART.
This will trigger implicit open/release via blkdev_get/put_whole()
later. dcssblk_release() will then deadlock on dcssblk_devices_sem
semaphore, which is already held from dcssblk_add_store() when calling
device_add_disk().
dcssblk does not support partitions (DCSSBLK_MINORS_PER_DISK == 1), and
never scanned partitions before. Therefore restore the previous
behavior, and explicitly disallow partition scanning by setting the
GENHD_FL_NO_PART flag. This will also prevent this deadlock scenario.
Fixes: 1ebe2e5f9d68 ("block: remove GENHD_FL_EXT_DEVT")
Cc: <stable@vger.kernel.org> # 5.17+
Signed-off-by: Gerald Schaefer <gerald.schaefer@linux.ibm.com>
Acked-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
Diffstat (limited to 'include/linux')
0 files changed, 0 insertions, 0 deletions