diff options
author | yangerkun | 2020-09-05 19:25:56 +0800 |
---|---|---|
committer | Jens Axboe | 2020-09-29 08:10:17 -0600 |
commit | 632bfb6323799c087fcb4108dfe59518609667a7 (patch) | |
tree | 82a008b131427f22482b359a62434ebc77f8421d /include/net | |
parent | 3aab91774bbd8e571cfaddaf839aafd07718333c (diff) |
blk-mq: call commit_rqs while list empty but error happen
Blk-mq should call commit_rqs once 'bd.last != true' and no more
request will come(so virtscsi can kick the virtqueue, e.g.). We already
do that in 'blk_mq_dispatch_rq_list/blk_mq_try_issue_list_directly' while
list not empty and 'queued > 0'. However, we can seen the same scene
once the last request in list call queue_rq and return error like
BLK_STS_IOERR which will not requeue the request, and lead that list
empty but need call commit_rqs too(Or the request for virtscsi will stay
timeout until other request kick virtqueue).
We found this problem by do fsstress test with offline/online virtscsi
device repeat quickly.
Fixes: d666ba98f849 ("blk-mq: add mq_ops->commit_rqs()")
Reported-by: zhangyi (F) <yi.zhang@huawei.com>
Signed-off-by: yangerkun <yangerkun@huawei.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'include/net')
0 files changed, 0 insertions, 0 deletions