diff options
| author | Jiri Pirko | 2022-08-24 14:20:11 +0200 |
|---|---|---|
| committer | Jakub Kicinski | 2022-08-25 13:22:53 -0700 |
| commit | f94b606325c194adadaee2265b4db990802c4850 (patch) | |
| tree | b8c0ec9e33bbb6522be4209cbd0d4fcb5526c968 /include/net | |
| parent | 0c1989754f76b52bd30581ff543890cab8c75a9d (diff) | |
net: devlink: limit flash component name to match version returned by info_get()
Limit the acceptance of component name passed to cmd_flash_update() to
match one of the versions returned by info_get(), marked by version type.
This makes things clearer and enforces 1:1 mapping between exposed
version and accepted flash component.
Check VERSION_TYPE_COMPONENT version type during cmd_flash_update()
execution by calling info_get() with different "req" context.
That causes info_get() to lookup the component name instead of
filling-up the netlink message.
Remove "UPDATE_COMPONENT" flag which becomes used.
Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'include/net')
| -rw-r--r-- | include/net/devlink.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/include/net/devlink.h b/include/net/devlink.h index f50a002e5023..1f7026011856 100644 --- a/include/net/devlink.h +++ b/include/net/devlink.h @@ -624,8 +624,7 @@ struct devlink_flash_update_params { u32 overwrite_mask; }; -#define DEVLINK_SUPPORT_FLASH_UPDATE_COMPONENT BIT(0) -#define DEVLINK_SUPPORT_FLASH_UPDATE_OVERWRITE_MASK BIT(1) +#define DEVLINK_SUPPORT_FLASH_UPDATE_OVERWRITE_MASK BIT(0) struct devlink_region; struct devlink_info_req; |