aboutsummaryrefslogtreecommitdiff
path: root/init
diff options
context:
space:
mode:
authorDavid Howells2014-05-21 14:48:05 +0100
committerDavid Howells2014-05-21 14:48:05 +0100
commit6c67c7c38cf32c2a9cbccb6b21aadf61a85fbfb4 (patch)
treed7e2b13f2ff270892babb8bc01799d71aded154c /init
parent60b5f90d0fac7585f1a43ccdad06787b97eda0ab (diff)
AFS: Fix cache manager service handlers
Fix the cache manager RPC service handlers. The afs_send_empty_reply() and afs_send_simple_reply() functions: (a) Kill the call and free up the buffers associated with it if they fail. (b) Return with call intact if it they succeed. However, none of the callers actually check the result or clean up if successful - and may use the now non-existent data if it fails. This was detected by Dan Carpenter using a static checker: The patch 08e0e7c82eea: "[AF_RXRPC]: Make the in-kernel AFS filesystem use AF_RXRPC." from Apr 26, 2007, leads to the following static checker warning: "fs/afs/cmservice.c:155 SRXAFSCB_CallBack() warn: 'call' was already freed." Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'init')
0 files changed, 0 insertions, 0 deletions