diff options
author | Peter Zijlstra | 2024-07-31 12:43:21 +0200 |
---|---|---|
committer | Peter Zijlstra | 2024-07-31 12:57:39 +0200 |
commit | 224fa3552029a3d14bec7acf72ded8171d551b88 (patch) | |
tree | b841485555f36065017bb998f0e2629d3447289f /kernel/configs | |
parent | 6623b0217d0c9bed80bfa43b778ce1c0eb03b497 (diff) |
jump_label: Fix the fix, brown paper bags galore
Per the example of:
!atomic_cmpxchg(&key->enabled, 0, 1)
the inverse was written as:
atomic_cmpxchg(&key->enabled, 1, 0)
except of course, that while !old is only true for old == 0, old is
true for everything except old == 0.
Fix it to read:
atomic_cmpxchg(&key->enabled, 1, 0) == 1
such that only the 1->0 transition returns true and goes on to disable
the keys.
Fixes: 83ab38ef0a0b ("jump_label: Fix concurrency issues in static_key_slow_dec()")
Reported-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Darrick J. Wong <djwong@kernel.org>
Link: https://lkml.kernel.org/r/20240731105557.GY33588@noisy.programming.kicks-ass.net
Diffstat (limited to 'kernel/configs')
0 files changed, 0 insertions, 0 deletions