diff options
| author | Paolo Abeni | 2023-06-20 18:24:23 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2023-07-01 13:16:22 +0200 |
| commit | 69925a346acb70be33059f4940ed703ffe0b0756 (patch) | |
| tree | af8ebc5f92fbb654d3ba6cf2433f7d3300bce9e1 /kernel/groups.c | |
| parent | 42a018a796d1eedb0d7c38b2778ef3dbf05aca36 (diff) | |
mptcp: ensure listener is unhashed before updating the sk status
commit 57fc0f1ceaa4016354cf6f88533e20b56190e41a upstream.
The MPTCP protocol access the listener subflow in a lockless
manner in a couple of places (poll, diag). That works only if
the msk itself leaves the listener status only after that the
subflow itself has been closed/disconnected. Otherwise we risk
deadlock in diag, as reported by Christoph.
Address the issue ensuring that the first subflow (the listener
one) is always disconnected before updating the msk socket status.
Reported-by: Christoph Paasch <cpaasch@apple.com>
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/407
Fixes: b29fcfb54cd7 ("mptcp: full disconnect implementation")
Cc: stable@vger.kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'kernel/groups.c')
0 files changed, 0 insertions, 0 deletions