diff options
| author | Dan Carpenter | 2023-04-21 13:42:41 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2023-05-30 14:03:22 +0100 |
| commit | 225a5f394b09d3f86f9bd281c4956854605b312e (patch) | |
| tree | 7f48c2675d61d3467e30fad67bdb9ff0a4845a46 /kernel/irq | |
| parent | 55224690958cd888d3ed8326a3452c7be2a8dba5 (diff) | |
coresight: Fix signedness bug in tmc_etr_buf_insert_barrier_packet()
commit f67bc15e526bb9920683ad6c1891ff9e08981335 upstream.
This code generates a Smatch warning:
drivers/hwtracing/coresight/coresight-tmc-etr.c:947 tmc_etr_buf_insert_barrier_packet()
error: uninitialized symbol 'bufp'.
The problem is that if tmc_sg_table_get_data() returns -EINVAL, then
when we test if "len < CORESIGHT_BARRIER_PKT_SIZE", the negative "len"
value is type promoted to a high unsigned long value which is greater
than CORESIGHT_BARRIER_PKT_SIZE. Fix this bug by adding an explicit
check for error codes.
Fixes: 75f4e3619fe2 ("coresight: tmc-etr: Add transparent buffer management")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/7d33e244-d8b9-4c27-9653-883a13534b01@kili.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'kernel/irq')
0 files changed, 0 insertions, 0 deletions