diff options
| author | Rafael J. Wysocki | 2016-01-16 00:54:53 +0100 |
|---|---|---|
| committer | Rafael J. Wysocki | 2016-01-19 15:27:49 +0100 |
| commit | 51164251f5c35e6596130ef0de94ffe65fe441e0 (patch) | |
| tree | 914eeadf8095d4fad848451c7928c80ddb17166a /kernel | |
| parent | 10475b34f4d71cf71cfe7c5d1f27d8ff3a4eb9bc (diff) | |
sched / idle: Drop default_idle_call() fallback from call_cpuidle()
After commit 9c4b2867ed7c (cpuidle: menu: Fix menu_select() for
CPUIDLE_DRIVER_STATE_START == 0) it is clear that menu_select()
cannot return negative values. Moreover, ladder_select_state()
will never return a negative value too, so make find_deepest_state()
return non-negative values too and drop the default_idle_call()
fallback from call_cpuidle().
This eliminates one branch from the idle loop and makes the governors
and find_deepest_state() handle the case when all states have been
disabled from sysfs consistently.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Ingo Molnar <mingo@kernel.org>
Tested-by: Sudeep Holla <sudeep.holla@arm.com>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/sched/idle.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c index 4a2ef5a02fd3..34852ee70d54 100644 --- a/kernel/sched/idle.c +++ b/kernel/sched/idle.c @@ -97,12 +97,6 @@ void default_idle_call(void) static int call_cpuidle(struct cpuidle_driver *drv, struct cpuidle_device *dev, int next_state) { - /* Fall back to the default arch idle method on errors. */ - if (next_state < 0) { - default_idle_call(); - return next_state; - } - /* * The idle task must be scheduled, it is pointless to go to idle, just * update no idle residency and return. |