diff options
| author | David Howells | 2013-03-13 14:59:48 -0700 |
|---|---|---|
| committer | Linus Torvalds | 2013-03-13 15:21:49 -0700 |
| commit | 415586c9e6d35ca116af714d7d0bea9c9f998ce5 (patch) | |
| tree | fe71b4aeed7ba7199419077770c15e65523bd50e /lib/crc32defs.h | |
| parent | ca044f9a9ed492f0f7e52df999c10ca6f7cfc5c0 (diff) | |
UAPI: fix endianness conditionals in M32R's asm/stat.h
In the UAPI header files, __BIG_ENDIAN and __LITTLE_ENDIAN must be
compared against __BYTE_ORDER in preprocessor conditionals where these are
exposed to userspace (that is they're not inside __KERNEL__ conditionals).
However, in the main kernel the norm is to check for
"defined(__XXX_ENDIAN)" rather than comparing against __BYTE_ORDER and
this has incorrectly leaked into the userspace headers.
The definition of struct stat64 in M32R's asm/stat.h is wrong in this way.
Note that userspace will likely interpret the field order incorrectly as
the big-endian variant on little-endian machines - depending on header
inclusion order.
[!!!] NOTE [!!!] This patch may adversely change the userspace API. It might
be better to fix the ordering of st_blocks and __pad4 in struct stat64.
Signed-off-by: David Howells <dhowells@redhat.com>
Cc: Hirokazu Takata <takata@linux-m32r.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib/crc32defs.h')
0 files changed, 0 insertions, 0 deletions