diff options
author | Elena Reshetova | 2017-10-20 12:53:33 +0300 |
---|---|---|
committer | Anna Schumaker | 2017-11-17 13:47:59 -0500 |
commit | 2b28a7bee4539d27f4ec3b0298f03bfd83d4f794 (patch) | |
tree | eae9a1b4816de726573ee4367dc47c9a36a1d6a3 /lib/dma-debug.c | |
parent | eba6dd691743a9d7a57735f36bf6946fc58878ec (diff) |
fs, nfs: convert pnfs_layout_hdr.plh_refcount from atomic_t to refcount_t
atomic_t variables are currently used to implement reference
counters with the following properties:
- counter is initialized to 1 using atomic_set()
- a resource is freed upon counter reaching zero
- once counter reaches zero, its further
increments aren't allowed
- counter schema uses basic atomic operations
(set, inc, inc_not_zero, dec_and_test, etc.)
Such atomic variables should be converted to a newly provided
refcount_t type and API that prevents accidental counter overflows
and underflows. This is important since overflows and underflows
can lead to use-after-free situation and be exploitable.
The variable pnfs_layout_hdr.plh_refcount is used as pure reference counter.
Convert it to refcount_t and fix up the operations.
Suggested-by: Kees Cook <keescook@chromium.org>
Reviewed-by: David Windsor <dwindsor@gmail.com>
Reviewed-by: Hans Liljestrand <ishkamiel@gmail.com>
Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Diffstat (limited to 'lib/dma-debug.c')
0 files changed, 0 insertions, 0 deletions