aboutsummaryrefslogtreecommitdiff
path: root/lib/locking-selftest-spin-softirq.h
diff options
context:
space:
mode:
authorJay Freyensee2016-08-17 15:00:26 -0700
committerSagi Grimberg2016-08-18 09:58:05 +0300
commitf994d9dc28bc27353acde2caaf718222d92a3e24 (patch)
treef54079f734752cc79dc3269a2dd3de2370200d9f /lib/locking-selftest-spin-softirq.h
parentb825b44c4ef4dabfdaf4e82db2263d377ac45d67 (diff)
fabrics: define admin sqsize min default, per spec
Upon admin queue connect(), the rdma qp was being set based on NVMF_AQ_DEPTH. However, the fabrics layer was using the sqsize field value set for I/O queues for the admin queue, which threw the nvme layer and rdma layer off-whack: root@fedora23-fabrics-host1 nvmf]# dmesg [ 3507.798642] nvme_fabrics: nvmf_connect_admin_queue():admin sqsize being sent is: 128 [ 3507.798858] nvme nvme0: creating 16 I/O queues. [ 3507.896407] nvme nvme0: new ctrl: NQN "nullside-nqn", addr 192.168.1.3:4420 Thus, to have a different admin queue value, we use NVMF_AQ_DEPTH for connect() and RDMA private data as the minimum depth specified in the NVMe-over-Fabrics 1.0 spec (and in that RDMA private data we treat hrqsize as 1's-based value, per current understanding of the fabrics spec). Reported-by: Daniel Verkamp <daniel.verkamp@intel.com> Signed-off-by: Jay Freyensee <james_p_freyensee@linux.intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Diffstat (limited to 'lib/locking-selftest-spin-softirq.h')
0 files changed, 0 insertions, 0 deletions