diff options
author | Jan Beulich | 2021-02-15 08:56:44 +0100 |
---|---|---|
committer | Juergen Gross | 2021-02-15 08:56:44 +0100 |
commit | 871997bc9e423f05c7da7c9178e62dde5df2a7f8 (patch) | |
tree | 31bdf5ee41af83e487cd234fa7b947e5c9165a8b /lib/nlattr.c | |
parent | 7c77474b2d22176d2bfb592ec74e0f2cb71352c9 (diff) |
xen-blkback: fix error handling in xen_blkbk_map()
The function uses a goto-based loop, which may lead to an earlier error
getting discarded by a later iteration. Exit this ad-hoc loop when an
error was encountered.
The out-of-memory error path additionally fails to fill a structure
field looked at by xen_blkbk_unmap_prepare() before inspecting the
handle which does get properly set (to BLKBACK_INVALID_HANDLE).
Since the earlier exiting from the ad-hoc loop requires the same field
filling (invalidation) as that on the out-of-memory path, fold both
paths. While doing so, drop the pr_alert(), as extra log messages aren't
going to help the situation (the kernel will log oom conditions already
anyway).
This is XSA-365.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Julien Grall <julien@xen.org>
Signed-off-by: Juergen Gross <jgross@suse.com>
Diffstat (limited to 'lib/nlattr.c')
0 files changed, 0 insertions, 0 deletions