diff options
author | Douglas Anderson | 2022-02-23 08:34:48 -0800 |
---|---|---|
committer | Rafael J. Wysocki | 2022-03-04 18:26:54 +0100 |
commit | b4060db9251f919506e4d672737c6b8ab9a84701 (patch) | |
tree | cc126422a607ffcc5b8be093c54dc75e11b32e72 /net/dsa | |
parent | 7e57714cd0ad2d5bb90e50b5096a0e671dec1ef3 (diff) |
PM: runtime: Have devm_pm_runtime_enable() handle pm_runtime_dont_use_autosuspend()
The PM Runtime docs say:
Drivers in ->remove() callback should undo the runtime PM changes done
in ->probe(). Usually this means calling pm_runtime_disable(),
pm_runtime_dont_use_autosuspend() etc.
From grepping code, it's clear that many people aren't aware of the
need to call pm_runtime_dont_use_autosuspend().
When brainstorming solutions, one idea that came up was to leverage
the new-ish devm_pm_runtime_enable() function. The idea here is that:
* When the devm action is called we know that the driver is being
removed. It's the perfect time to undo the use_autosuspend.
* The code of pm_runtime_dont_use_autosuspend() already handles the
case of being called when autosuspend wasn't enabled.
Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'net/dsa')
0 files changed, 0 insertions, 0 deletions