diff options
author | Xie He | 2020-10-03 15:41:05 -0700 |
---|---|---|
committer | David S. Miller | 2020-10-04 15:11:35 -0700 |
commit | f5083d0cee08a4b87d5d7a5c57f60ec128bff997 (patch) | |
tree | 469dafc9a9baa4e0675a120c510c4868f13c170d /net/dsa | |
parent | 3e233cac4278366547fad3176ecf3d8d5944e2ea (diff) |
drivers/net/wan/hdlc_fr: Improvements to the code of pvc_xmit
1. Keep the code for the normal (non-error) flow at the lowest
indentation level. And use "goto drop" for all error handling.
2. Replace code that pads short Ethernet frames with a "__skb_pad" call.
3. Change "dev_kfree_skb" to "kfree_skb" in error handling code.
"kfree_skb" is the correct function to call when dropping an skb due to
an error. "dev_kfree_skb", which is an alias of "consume_skb", is for
dropping skbs normally (not due to an error).
Cc: Krzysztof Halasa <khc@pm.waw.pl>
Cc: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Xie He <xie.he.0141@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dsa')
0 files changed, 0 insertions, 0 deletions