diff options
author | Christian Marangi | 2023-10-02 16:08:05 +0200 |
---|---|---|
committer | Greg Kroah-Hartman | 2023-10-10 22:00:38 +0200 |
commit | 4674e9626beb366de76b87378121d52c778b070f (patch) | |
tree | 1cb4adf49de2eb5b982551aa0e4773eb048118ba /net/kcm | |
parent | 3a72decd6b49ff11a894aabd4d9b3025f046fe61 (diff) |
net: ethernet: mediatek: disable irq before schedule napi
commit fcdfc462881d8acf9db77f483b2c821e286ca97b upstream.
While searching for possible refactor of napi_schedule_prep and
__napi_schedule it was notice that the mtk eth driver disable the
interrupt for rx and tx AFTER napi is scheduled.
While this is a very hard to repro case it might happen to have
situation where the interrupt is disabled and never enabled again as the
napi completes and the interrupt is enabled before.
This is caused by the fact that a napi driven by interrupt expect a
logic with:
1. interrupt received. napi prepared -> interrupt disabled -> napi
scheduled
2. napi triggered. ring cleared -> interrupt enabled -> wait for new
interrupt
To prevent this case, disable the interrupt BEFORE the napi is
scheduled.
Fixes: 656e705243fd ("net-next: mediatek: add support for MT7623 ethernet")
Cc: stable@vger.kernel.org
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Link: https://lore.kernel.org/r/20231002140805.568-1-ansuelsmth@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/kcm')
0 files changed, 0 insertions, 0 deletions