diff options
| author | Samuel Mendoza-Jonas | 2018-11-16 15:51:54 +1100 |
|---|---|---|
| committer | David S. Miller | 2018-11-17 21:09:49 -0800 |
| commit | 60ab49bfe4fa576c5b1d98b9dfc523bfcb3c610c (patch) | |
| tree | 719f2b51331a26ec8700aa731e66fbaf59459178 /net/ncsi/ncsi-aen.c | |
| parent | 2391b0030e241386d710df10e53e2cfc3c5d4fc1 (diff) | |
net/ncsi: Don't enable all channels when HWA available
NCSI hardware arbitration allows multiple packages to be enabled at once
and share the same wiring. If the NCSI driver recognises that HWA is
available it unconditionally enables all packages and channels; but that
is a configuration decision rather than something required by HWA.
Additionally the current implementation will not failover on link events
which can cause connectivity to be lost unless the interface is manually
bounced.
Retain basic HWA support but remove the separate configuration path to
enable all channels, leaving this to be handled by a later
implementation.
Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ncsi/ncsi-aen.c')
| -rw-r--r-- | net/ncsi/ncsi-aen.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c index 25e483e8278b..65f47a648be3 100644 --- a/net/ncsi/ncsi-aen.c +++ b/net/ncsi/ncsi-aen.c @@ -86,8 +86,7 @@ static int ncsi_aen_handler_lsc(struct ncsi_dev_priv *ndp, !(state == NCSI_CHANNEL_ACTIVE && !(data & 0x1))) return 0; - if (!(ndp->flags & NCSI_DEV_HWA) && - state == NCSI_CHANNEL_ACTIVE) + if (state == NCSI_CHANNEL_ACTIVE) ndp->flags |= NCSI_DEV_RESHUFFLE; ncsi_stop_channel_monitor(nc); |