diff options
| author | Eric Dumazet | 2011-05-11 18:22:36 +0000 |
|---|---|---|
| committer | David S. Miller | 2011-05-12 17:27:10 -0400 |
| commit | 1769192a3c50778e03352a3d95faec830d47ba55 (patch) | |
| tree | 9764b821abc0ddc4fa22c239e00460636aa77203 /net/sctp/socket.c | |
| parent | 3c709f8fb43e07a0403bba4a8ca7ba00ab874994 (diff) | |
l2tp: fix potential rcu race
While trying to remove useless synchronize_rcu() calls, I found l2tp is
indeed incorrectly using two of such calls, but also bumps tunnel
refcount after list insertion.
tunnel refcount must be incremented before being made publically visible
by rcu readers.
This fix can be applied to 2.6.35+ and might need a backport for older
kernels, since things were shuffled in commit fd558d186df2c
(l2tp: Split pppol2tp patch into separate l2tp and ppp parts)
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
CC: James Chapman <jchapman@katalix.com>
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp/socket.c')
0 files changed, 0 insertions, 0 deletions