diff options
| author | Chuck Lever | 2023-05-11 11:48:13 -0400 |
|---|---|---|
| committer | Jakub Kicinski | 2023-05-24 22:05:24 -0700 |
| commit | 7afc6d0a107ffbd448c96eb2458b9e64a5af7860 (patch) | |
| tree | 198633b29853ec7e54dada930170baca157aa4c7 /net | |
| parent | 7ea9c1ec66bc099b0bfba961a8a46dfe25d7d8e4 (diff) | |
net/handshake: Fix uninitialized local variable
trace_handshake_cmd_done_err() simply records the pointer in @req,
so initializing it to NULL is sufficient and safe.
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Fixes: 3b3009ea8abb ("net/handshake: Create a NETLINK service for handling handshake requests")
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/handshake/netlink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/handshake/netlink.c b/net/handshake/netlink.c index f5dc170689d9..16a4bde648ba 100644 --- a/net/handshake/netlink.c +++ b/net/handshake/netlink.c @@ -157,8 +157,8 @@ out_status: int handshake_nl_done_doit(struct sk_buff *skb, struct genl_info *info) { struct net *net = sock_net(skb->sk); + struct handshake_req *req = NULL; struct socket *sock = NULL; - struct handshake_req *req; int fd, status, err; if (GENL_REQ_ATTR_CHECK(info, HANDSHAKE_A_DONE_SOCKFD)) |