diff options
author | Guenter Roeck | 2015-08-17 13:45:36 -0700 |
---|---|---|
committer | David S. Miller | 2015-08-17 14:06:16 -0700 |
commit | 62ee783bf1f872ba879e088a669b04afebee899b (patch) | |
tree | 98fcd45c8e6c0e382f7a6961f9c8808994a1484a /net | |
parent | c87acb2558db7a870575dd8e14ded2e5acbdc295 (diff) |
smsc911x: Fix crash seen if neither ACPI nor OF is configured or used
Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes
the call to smsc911x_probe_config() unconditional, and no longer fails if
there is no device node. device_get_phy_mode() is called unconditionally,
and if there is no phy node configured returns an error code. This error
code is assigned to phy_interface, and interpreted elsewhere in the code
as valid phy mode. This in turn causes qemu to crash when running a
variant of realview_pb_defconfig.
qemu: hardware error: lan9118_read: Bad reg 0x86
Fixes: 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT")
Cc: Jeremy Linton <jeremy.linton@arm.com>
Cc Graeme Gregory <graeme.gregory@linaro.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions