aboutsummaryrefslogtreecommitdiff
path: root/samples
diff options
context:
space:
mode:
authorJames Smart2017-11-29 15:11:55 -0800
committerChristoph Hellwig2018-01-08 11:01:56 +0100
commit9ce1f2e12e017607fe17a67cea79ebcf0184e5b3 (patch)
treec9655f7a183f961974a7638a88c27a3eb2efbd6e /samples
parentb6f807738b5e3a24eda3ea6864abc18d10279e69 (diff)
nvmet-fc: cleanup nvmet add_port/remove_port
The current fc transport add_port routine validates that there is a matching port to the target port config. It then takes a reference on the targetport. The del_port removes the reference. Unfortunately, if the LLDD undergoes a hw reset or driver unload and wants to unreg the targetport, due to the reference, the targetport effectively can't be removed. It requires the admin to remove the port from the nvmet config first, which calls the del_port. Note: it appears nvmetcli clear skips over the del_port call (I'm not attempting to change that). There's no real reason to take the reference. With FC, there is nothing to enable or disable as the presence of the FC targetport implicitly means its enabled, and removal of the targtport means its disabled. Change add_port to simply validate and change remove_port to a noop. No references are taken on the targetport. Signed-off-by: James Smart <james.smart@broadcom.com> Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'samples')
0 files changed, 0 insertions, 0 deletions