diff options
author | Shengjiu Wang | 2019-11-12 18:46:42 +0800 |
---|---|---|
committer | Mark Brown | 2019-11-20 17:16:27 +0000 |
commit | 5cca59516de5df9de6bdecb328dd55fb5bcccb41 (patch) | |
tree | b74d83e539eba2c4299142089697514ae8841ee6 /tools | |
parent | 4ec48e7cbe6e70352c802b5cb172b00ebd8af8e0 (diff) |
ASoC: soc-pcm: check symmetry before hw_params
This reverts commit 957ce0c6b8a1f (ASoC: soc-pcm: check symmetry after
hw_params).
That commit cause soc_pcm_params_symmetry can't take effect.
cpu_dai->rate, cpu_dai->channels and cpu_dai->sample_bits
are updated in the middle of soc_pcm_hw_params, so move
soc_pcm_params_symmetry to the end of soc_pcm_hw_params is
not a good solution, for judgement of symmetry in the function
is always true.
FIXME:
According to the comments of that commit, I think the case
described in the commit should disable symmetric_rates
in Back-End, rather than changing the position of
soc_pcm_params_symmetry.
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Link: https://lore.kernel.org/r/1573555602-5403-1-git-send-email-shengjiu.wang@nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions