diff options
| author | Julien Thierry | 2020-03-27 15:28:39 +0000 |
|---|---|---|
| committer | Ingo Molnar | 2020-04-22 10:53:49 +0200 |
| commit | a70266b5b2e1c4262566a52f2ef16bdcde90f99b (patch) | |
| tree | 15144c5d29d98b975db0489d44a4151127ce5cf5 /tools | |
| parent | aa5847270a0eba62e5ab8445163c0ac974844598 (diff) | |
objtool: Remove redundant checks on operand type
POP operations are already in the code path where the destination
operand is OP_DEST_REG. There is no need to check the operand type
again.
Signed-off-by: Julien Thierry <jthierry@redhat.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/objtool/check.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 4b170fd08a28..c18eca151b6d 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -1715,15 +1715,13 @@ static int update_insn_state(struct instruction *insn, struct insn_state *state) case OP_SRC_POP: case OP_SRC_POPF: - if (!state->drap && op->dest.type == OP_DEST_REG && - op->dest.reg == cfa->base) { + if (!state->drap && op->dest.reg == cfa->base) { /* pop %rbp */ cfa->base = CFI_SP; } if (state->drap && cfa->base == CFI_BP_INDIRECT && - op->dest.type == OP_DEST_REG && op->dest.reg == state->drap_reg && state->drap_offset == -state->stack_size) { |