From 37f40f81e589839c17ed99a103bc1bc5f7343313 Mon Sep 17 00:00:00 2001 From: Yang Yingliang Date: Wed, 23 Feb 2022 16:49:54 +0800 Subject: net: marvell: prestera: Fix return value check in prestera_kern_fib_cache_find() rhashtable_lookup_fast() returns NULL pointer not ERR_PTR(), so it can return fib_node directly in prestera_kern_fib_cache_find(). Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20220223084954.1771075-2-yangyingliang@huawei.com Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/marvell/prestera/prestera_router.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/prestera/prestera_router.c b/drivers/net/ethernet/marvell/prestera/prestera_router.c index 54ebda61bfea..6c5618cf4f08 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_router.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_router.c @@ -68,7 +68,7 @@ prestera_kern_fib_cache_find(struct prestera_switch *sw, fib_cache = rhashtable_lookup_fast(&sw->router->kern_fib_cache_ht, key, __prestera_kern_fib_cache_ht_params); - return IS_ERR(fib_cache) ? NULL : fib_cache; + return fib_cache; } static void -- cgit v1.2.3