From afe120c777b7a6aa23b8c8a5fedae9201a7ced0c Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Fri, 23 Nov 2018 10:15:05 +0300 Subject: ic3: off by one in mode_show() This should be >= ARRAY_SIZE() to avoid reading one element beyond the end of the array. Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure") Signed-off-by: Dan Carpenter Signed-off-by: Boris Brezillon --- drivers/i3c/master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/i3c/master.c') diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index bda4b9613e53..c39f89d2deba 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -475,7 +475,7 @@ static ssize_t mode_show(struct device *dev, i3c_bus_normaluse_lock(i3cbus); if (i3cbus->mode < 0 || - i3cbus->mode > ARRAY_SIZE(i3c_bus_mode_strings) || + i3cbus->mode >= ARRAY_SIZE(i3c_bus_mode_strings) || !i3c_bus_mode_strings[i3cbus->mode]) ret = sprintf(buf, "unknown\n"); else -- cgit v1.2.3