From a56af062ae7cdc9759ed61d1d3d173f28c79510a Mon Sep 17 00:00:00 2001 From: Chunyan Zhang Date: Wed, 31 Mar 2021 11:16:45 +0800 Subject: iommu/sprd: Fix parameter type warning The second parameter of clk_get_optional() is "const char *", so use NULL instead of integer 0 to fix a sparse warning like: ">> drivers/iommu/sprd-iommu.c:456:42: sparse: sparse: Using plain integer as NULL pointer" Also this patch changes to use the resource-managed variant of clk_get_optional(), then there's no need to add clk_put() which is missed in the current driver. Reported-by: kernel test robot Signed-off-by: Chunyan Zhang Link: https://lore.kernel.org/r/20210331031645.1001913-1-zhang.lyra@gmail.com Signed-off-by: Joerg Roedel --- drivers/iommu/sprd-iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/iommu/sprd-iommu.c') diff --git a/drivers/iommu/sprd-iommu.c b/drivers/iommu/sprd-iommu.c index e1dc2f7d5639..3811a5085b50 100644 --- a/drivers/iommu/sprd-iommu.c +++ b/drivers/iommu/sprd-iommu.c @@ -453,7 +453,7 @@ static int sprd_iommu_clk_enable(struct sprd_iommu_device *sdev) { struct clk *eb; - eb = clk_get_optional(sdev->dev, 0); + eb = devm_clk_get_optional(sdev->dev, NULL); if (!eb) return 0; -- cgit v1.2.3