From 1f3d2d9edc832bdd5507130446abf1c8d2923ac5 Mon Sep 17 00:00:00 2001
From: Himangi Saraogi
Date: Tue, 10 Jun 2014 19:48:47 +0530
Subject: aic7xxx: Use kstrdup
Use kstrdup when the goal of an allocation is copy a string into the
allocated region.
The Coccinelle semantic patch that makes this change is as follows:
//
@@
expression from,to;
expression flag,E1,E2;
statement S;
@@
- to = kmalloc(strlen(from) + 1,flag);
+ to = kstrdup(from, flag);
... when != \(from = E1 \| to = E1 \)
if (to==NULL || ...) S
... when != \(from = E2 \| to = E2 \)
- strcpy(to, from);
//
Signed-off-by: Himangi Saraogi
Acked-by: Julia Lawall
Signed-off-by: Christoph Hellwig
---
drivers/scsi/aic7xxx/aic7xxx_osm_pci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
(limited to 'drivers/scsi/aic7xxx/aic7xxx_osm_pci.c')
diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm_pci.c b/drivers/scsi/aic7xxx/aic7xxx_osm_pci.c
index ee05e8410754..0fc14dac7070 100644
--- a/drivers/scsi/aic7xxx/aic7xxx_osm_pci.c
+++ b/drivers/scsi/aic7xxx/aic7xxx_osm_pci.c
@@ -225,10 +225,9 @@ ahc_linux_pci_dev_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
ahc_get_pci_bus(pci),
ahc_get_pci_slot(pci),
ahc_get_pci_function(pci));
- name = kmalloc(strlen(buf) + 1, GFP_ATOMIC);
+ name = kstrdup(buf, GFP_ATOMIC);
if (name == NULL)
return (-ENOMEM);
- strcpy(name, buf);
ahc = ahc_alloc(NULL, name);
if (ahc == NULL)
return (-ENOMEM);
--
cgit v1.2.3