From 63848854256a024a19435e87d6bc76fffa65e81e Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Thu, 25 Oct 2012 00:39:33 +0200 Subject: qt-faststart: Check the ftello() return codes This silences a warning in the coverity static analyzer. Signed-off-by: Martin Storsjö --- tools/qt-faststart.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'tools') diff --git a/tools/qt-faststart.c b/tools/qt-faststart.c index 2b2e00ca57..5c511a0154 100644 --- a/tools/qt-faststart.c +++ b/tools/qt-faststart.c @@ -137,11 +137,11 @@ int main(int argc, char *argv[]) goto error_out; } if (fseeko(infile, -ATOM_PREAMBLE_SIZE, SEEK_CUR) || - fread(ftyp_atom, atom_size, 1, infile) != 1) { + fread(ftyp_atom, atom_size, 1, infile) != 1 || + (start_offset = ftello(infile)) < 0) { perror(argv[1]); goto error_out; } - start_offset = ftello(infile); } else { int ret; /* 64-bit special case */ @@ -202,6 +202,10 @@ int main(int argc, char *argv[]) goto error_out; } last_offset = ftello(infile); + if (last_offset < 0) { + perror(argv[1]); + goto error_out; + } moov_atom_size = atom_size; moov_atom = malloc(moov_atom_size); if (!moov_atom) { -- cgit v1.2.3