diff options
author | Bin Liu | 2018-11-12 09:43:22 -0600 |
---|---|---|
committer | Vinod Koul | 2018-12-05 14:01:59 +0530 |
commit | 59861547ec9a9736e7882f6fb0c096a720ff811a (patch) | |
tree | ebe4c43170e93eee4c31e7ab1b74aa42ec7c4546 /drivers/dma/mcf-edma.c | |
parent | 64068853bc77786d1a28abb4087d6a3e93aedbe2 (diff) |
dmaengine: cppi41: delete channel from pending list when stop channel
The driver defines three states for a cppi channel.
- idle: .chan_busy == 0 && not in .pending list
- pending: .chan_busy == 0 && in .pending list
- busy: .chan_busy == 1 && not in .pending list
There are cases in which the cppi channel could be in the pending state
when cppi41_dma_issue_pending() is called after cppi41_runtime_suspend()
is called.
cppi41_stop_chan() has a bug for these cases to set channels to idle state.
It only checks the .chan_busy flag, but not the .pending list, then later
when cppi41_runtime_resume() is called the channels in .pending list will
be transitioned to busy state.
Removing channels from the .pending list solves the problem.
Fixes: 975faaeb9985 ("dma: cppi41: start tear down only if channel is busy")
Cc: stable@vger.kernel.org # v3.15+
Signed-off-by: Bin Liu <b-liu@ti.com>
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/mcf-edma.c')
0 files changed, 0 insertions, 0 deletions