diff options
| author | Robert Schlabbach | 2022-01-06 23:49:47 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab | 2022-01-10 15:56:00 +0100 |
| commit | 95c4cd1d19e3e1d4894457a6f015e3a045bc9b06 (patch) | |
| tree | b77395d00e487027ea1302d062980c4faa92fc43 /drivers/media/tuners | |
| parent | a89eeb9937a0124e609e9355cd48cdfe35c8b8b7 (diff) | |
media: si2157: fix 6MHz & 6.1MHz bandwidth setting
Commit 98c65a3dac95 ("media: si2157: add support for 1.7MHz and 6.1
MHz") introduced two bugs: The 6.1MHz setting was always used for any
bandwidth less than 7MHz due to missing "else" keywords, and then the
setting was not specified as decimal 10, but as hexadecimal 0x10, which
makes the tuner refuse the tune command. In sum, it is not possible to
tune to any channels of less than 7MHz bandwidth anymore.
Add the missing "else" keywords and convert all bandwidth settings to
decimal to avoid any future decimal vs. hexadecimal confusion.
Remove the use of the undefined bandwidth setting 0x0f for bandwidths
greater than 8MHz, which is also refused by the tune command, in favour
of using the default bandwidth setting 8 for any bandwidths greater than
7MHz.
Link: https://lore.kernel.org/linux-media/trinity-d0015ea1-1da5-4c7d-a75b-781fb26dc339-1641509387112@3c-app-gmx-bap68
Fixes: 98c65a3dac95 ("media: si2157: add support for 1.7MHz and 6.1 MHz")
Reported-by: Robert Schlabbach <robert_s@gmx.net>
Signed-off-by: Robert Schlabbach <robert_s@gmx.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Diffstat (limited to 'drivers/media/tuners')
| -rw-r--r-- | drivers/media/tuners/si2157.c | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c index 481c5c3b577d..76dc10dd2518 100644 --- a/drivers/media/tuners/si2157.c +++ b/drivers/media/tuners/si2157.c @@ -459,17 +459,15 @@ static int si2157_set_params(struct dvb_frontend *fe) } if (SUPPORTS_1700KHz(dev) && c->bandwidth_hz <= 1700000) - bandwidth = 0x09; - if (c->bandwidth_hz <= 6000000) - bandwidth = 0x06; - if (SUPPORTS_1700KHz(dev) && c->bandwidth_hz <= 6100000) - bandwidth = 0x10; + bandwidth = 9; + else if (c->bandwidth_hz <= 6000000) + bandwidth = 6; + else if (SUPPORTS_1700KHz(dev) && c->bandwidth_hz <= 6100000) + bandwidth = 10; else if (c->bandwidth_hz <= 7000000) - bandwidth = 0x07; - else if (c->bandwidth_hz <= 8000000) - bandwidth = 0x08; + bandwidth = 7; else - bandwidth = 0x0f; + bandwidth = 8; switch (c->delivery_system) { case SYS_ATSC: |