diff options
| author | Muhammad Usama Anjum | 2021-04-09 00:57:18 +0500 |
|---|---|---|
| committer | Mark Brown | 2021-04-09 13:44:02 +0100 |
| commit | e980048263ba72dcdbbf45d59e84c02001340f75 (patch) | |
| tree | ab30ddee7658437f0322cd4c9194105b6e79fad5 /drivers/spi/spi-orion.c | |
| parent | 4df2f5e1372e9eec8f9e1b4a3025b9be23487d36 (diff) | |
spi: orion: set devdata properly as it is being used later
If device_get_match_data returns NULL, devdata isn't being updated
properly. It is being used later in the function. Both devdata and
spi->devdata should be updated to avoid NULL pointer dereference.
Addresses-Coverity: ("NULL pointer dereference")
Fixes: 0e6521f13c2 ("spi: orion: Use device_get_match_data() helper")
Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com>
Link: https://lore.kernel.org/r/20210408195718.GA3075166@LEGION
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-orion.c')
| -rw-r--r-- | drivers/spi/spi-orion.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/spi/spi-orion.c b/drivers/spi/spi-orion.c index d02c5c9def20..34b31aba3981 100644 --- a/drivers/spi/spi-orion.c +++ b/drivers/spi/spi-orion.c @@ -676,7 +676,8 @@ static int orion_spi_probe(struct platform_device *pdev) spi->dev = &pdev->dev; devdata = device_get_match_data(&pdev->dev); - spi->devdata = devdata ? devdata : &orion_spi_dev_data; + devdata = devdata ? devdata : &orion_spi_dev_data; + spi->devdata = devdata; spi->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(spi->clk)) { |