diff options
| author | David Howells | 2018-04-04 13:41:28 +0100 |
|---|---|---|
| committer | David Howells | 2018-04-04 13:41:28 +0100 |
| commit | 402cb8dda949d9b8c0df20ad2527d139faad7ca1 (patch) | |
| tree | 83cdb77f5490a0990eade886aa7f8dd087864996 /fs/afs/volume.c | |
| parent | 08c2e3d087840cd1e7141b62d92f3dc897147984 (diff) | |
fscache: Attach the index key and aux data to the cookie
Attach copies of the index key and auxiliary data to the fscache cookie so
that:
(1) The callbacks to the netfs for this stuff can be eliminated. This
can simplify things in the cache as the information is still
available, even after the cache has relinquished the cookie.
(2) Simplifies the locking requirements of accessing the information as we
don't have to worry about the netfs object going away on us.
(3) The cache can do lazy updating of the coherency information on disk.
As long as the cache is flushed before reboot/poweroff, there's no
need to update the coherency info on disk every time it changes.
(4) Cookies can be hashed or put in a tree as the index key is easily
available. This allows:
(a) Checks for duplicate cookies can be made at the top fscache layer
rather than down in the bowels of the cache backend.
(b) Caching can be added to a netfs object that has a cookie if the
cache is brought online after the netfs object is allocated.
A certain amount of space is made in the cookie for inline copies of the
data, but if it won't fit there, extra memory will be allocated for it.
The downside of this is that live cache operation requires more memory.
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Anna Schumaker <anna.schumaker@netapp.com>
Tested-by: Steve Dickson <steved@redhat.com>
Diffstat (limited to 'fs/afs/volume.c')
| -rw-r--r-- | fs/afs/volume.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/afs/volume.c b/fs/afs/volume.c index b517a588781f..345cb2d675d2 100644 --- a/fs/afs/volume.c +++ b/fs/afs/volume.c @@ -225,6 +225,8 @@ void afs_activate_volume(struct afs_volume *volume) #ifdef CONFIG_AFS_FSCACHE volume->cache = fscache_acquire_cookie(volume->cell->cache, &afs_volume_cache_index_def, + &volume->vid, sizeof(volume->vid), + NULL, 0, volume, true); #endif @@ -245,7 +247,7 @@ void afs_deactivate_volume(struct afs_volume *volume) write_unlock(&volume->cell->proc_lock); #ifdef CONFIG_AFS_FSCACHE - fscache_relinquish_cookie(volume->cache, + fscache_relinquish_cookie(volume->cache, NULL, test_bit(AFS_VOLUME_DELETED, &volume->flags)); volume->cache = NULL; #endif |