diff options
| author | Michael Kerrisk (man-pages) | 2017-04-27 13:54:11 +0200 |
|---|---|---|
| committer | Linus Torvalds | 2017-04-27 10:45:09 -0700 |
| commit | 59372bbf3abd5b24a7f6f676a3968685c280f955 (patch) | |
| tree | 1b9fde933d8e9cbd7dec3c39521ca0cb16eed73d /fs/stat.c | |
| parent | f83246089ca09308425175d47f5e71e6da68b2ef (diff) | |
statx: correct error handling of NULL pathname
The change in commit 1e2f82d1e9d1 ("statx: Kill fd-with-NULL-path
support in favour of AT_EMPTY_PATH") to error on a NULL pathname to
statx() is inconsistent.
It results in the error EINVAL for a NULL pathname. Other system calls
with similar APIs (fchownat(), fstatat(), linkat()), return EFAULT.
The solution is simply to remove the EINVAL check. As I already pointed
out in [1], user_path_at*() and filename_lookup() will handle the NULL
pathname as per the other APIs, to correctly produce the error EFAULT.
[1] https://lkml.org/lkml/2017/4/26/561
Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Eric Sandeen <sandeen@sandeen.net>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/stat.c')
| -rw-r--r-- | fs/stat.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/stat.c b/fs/stat.c index 3d85747bd86e..a257b872a53d 100644 --- a/fs/stat.c +++ b/fs/stat.c @@ -567,8 +567,6 @@ SYSCALL_DEFINE5(statx, return -EINVAL; if ((flags & AT_STATX_SYNC_TYPE) == AT_STATX_SYNC_TYPE) return -EINVAL; - if (!filename) - return -EINVAL; error = vfs_statx(dfd, filename, flags, &stat, mask); if (error) |