diff options
| author | Elad Wexler | 2017-12-30 18:01:39 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2018-01-04 17:05:55 +0100 |
| commit | f7a5d7b3ab3c4865af85b431e1cd18b66b6c3b0e (patch) | |
| tree | 27125367abd5f9c54c204b4aa82f95a5c3ab6dca /tools/usb | |
| parent | cb48326493146b1022702b9b8f15460f7e9dbfc1 (diff) | |
tools: usb: usbip: fix fd leak in case of 'fread' failure
Fix possible resource leak: fd
Signed-off-by: Elad Wexler <elad.wexler@gmail.com>
Acked-by: Shuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'tools/usb')
| -rw-r--r-- | tools/usb/usbip/libsrc/usbip_device_driver.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/tools/usb/usbip/libsrc/usbip_device_driver.c b/tools/usb/usbip/libsrc/usbip_device_driver.c index b2dac82975af..ec3a0b794f15 100644 --- a/tools/usb/usbip/libsrc/usbip_device_driver.c +++ b/tools/usb/usbip/libsrc/usbip_device_driver.c @@ -92,7 +92,7 @@ int read_usb_vudc_device(struct udev_device *sdev, struct usbip_usb_device *dev) return -1; ret = fread((char *) &descr, sizeof(descr), 1, fd); if (ret < 0) - return -1; + goto err; fclose(fd); copy_descr_attr(dev, &descr, bDeviceClass); @@ -124,6 +124,9 @@ int read_usb_vudc_device(struct udev_device *sdev, struct usbip_usb_device *dev) name = udev_device_get_sysname(plat); strncpy(dev->busid, name, SYSFS_BUS_ID_SIZE); return 0; +err: + fclose(fd); + return -1; } static int is_my_device(struct udev_device *dev) |