aboutsummaryrefslogtreecommitdiff
path: root/board/nokia
diff options
context:
space:
mode:
authorPali Rohár2022-10-09 21:38:25 +0200
committerTom Rini2022-10-12 11:11:58 -0400
commitedb47d612fe9ddca77cd583f14c71517f065405f (patch)
treea1f2f84786fed424a19483f3f996e4454963cfd3 /board/nokia
parent767ecc5f9ff932c2f8361238d50c1dc6e7d07dce (diff)
Nokia RX-51: Fix double space key press
Space key is indicated by two different bits. Some HW models indicate press of space key only by the first bit. Qemu indicates it by both bits at the same time, which is currently interpreted by u-boot as double key press. Fix this issue by setting first bit when only second is set (to support HW models which indicate press only by second bit) and always clearing second bit before processing to not report double space key press. Signed-off-by: Pali Rohár <pali@kernel.org>
Diffstat (limited to 'board/nokia')
-rw-r--r--board/nokia/rx51/rx51.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/board/nokia/rx51/rx51.c b/board/nokia/rx51/rx51.c
index 9548c3c7be7..c1b4b91b607 100644
--- a/board/nokia/rx51/rx51.c
+++ b/board/nokia/rx51/rx51.c
@@ -561,7 +561,7 @@ static const char keymap[] = {
'q', 'o', 'p', ',', '\b', 0, 'a', 's',
'w', 'd', 'f', 'g', 'h', 'j', 'k', 'l',
'e', '.', 0, '\r', 0, 'z', 'x', 'c',
- 'r', 'v', 'b', 'n', 'm', ' ', ' ', 0,
+ 'r', 'v', 'b', 'n', 'm', ' ', 0, 0,
't', 0, 0, 0, 0, 0, 0, 0,
'y', 0, 0, 0, 0, 0, 0, 0,
'u', 0, 0, 0, 0, 0, 0, 0,
@@ -691,6 +691,10 @@ static int rx51_kp_tstc(struct udevice *dev)
mods = keys[4] >> 4;
keys[4] &= 0x0f;
+ /* space key is indicated by two different bits */
+ keys[3] |= (keys[3] & (1 << 6)) >> 1;
+ keys[3] &= ~(1 << 6);
+
for (c = 0; c < 8; c++) {
/* get newly pressed keys only */