diff options
| author | Wolfgang Denk | 2010-07-17 01:06:04 +0200 |
|---|---|---|
| committer | Wolfgang Denk | 2010-07-24 20:43:57 +0200 |
| commit | 47e26b1bf91ddef69f4a3892815c857db094cef9 (patch) | |
| tree | 7d688085d23779707c637703273f79bd3cca83e0 /common/cmd_strings.c | |
| parent | debb6299ac1180a08f29f88c6d782b21a9c98707 (diff) | |
cmd_usage(): simplify return code handling
Lots of code use this construct:
cmd_usage(cmdtp);
return 1;
Change cmd_usage() let it return 1 - then we can replace all these
ocurrances by
return cmd_usage(cmdtp);
This fixes a few places with incorrect return code handling, too.
Signed-off-by: Wolfgang Denk <wd@denx.de>
Diffstat (limited to 'common/cmd_strings.c')
| -rw-r--r-- | common/cmd_strings.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/common/cmd_strings.c b/common/cmd_strings.c index bbbb6b4da9f..144a6c18d7e 100644 --- a/common/cmd_strings.c +++ b/common/cmd_strings.c @@ -14,10 +14,8 @@ static char *start_addr, *last_addr; int do_strings(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) { - if (argc == 1) { - cmd_usage(cmdtp); - return 1; - } + if (argc == 1) + return cmd_usage(cmdtp); if ((flag & CMD_FLAG_REPEAT) == 0) { start_addr = (char *)simple_strtoul(argv[1], NULL, 16); |