diff options
| author | Rasmus Villemoes | 2020-11-20 11:45:35 +0100 |
|---|---|---|
| committer | Tom Rini | 2021-01-16 14:49:09 -0500 |
| commit | 31ce367cd10087b532431c023e4a95513ecdee5d (patch) | |
| tree | abe69d421178391a6cffe43b6c231d92f9100ef8 /lib | |
| parent | 2d572ede1185db2129685e8cedfb690a5e3c4d3d (diff) | |
lib/uuid.c: change prototype of uuid_guid_get_str()
There's no reason to require an appropriately sized output parameter
for the string, that's error-prone should the table ever grow an
element with a longer string. We can just return the const char*
pointer directly.
Update the only caller accordingly, and get rid of pointless ifdeffery
in the header so that the compiler always sees a declaration and can
thus do type-checking, whether or not PARTITION_TYPE_GUID is enabled
or not.
Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/uuid.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/lib/uuid.c b/lib/uuid.c index e62d5ca2643..6cfb6cd449d 100644 --- a/lib/uuid.c +++ b/lib/uuid.c @@ -122,20 +122,19 @@ int uuid_guid_get_bin(const char *guid_str, unsigned char *guid_bin) * uuid_guid_get_str() - this function get string for GUID. * * @param guid_bin - pointer to string with partition type guid [16B] - * @param guid_str - pointer to allocated partition type string [7B] + * + * Returns NULL if the type GUID is not known. */ -int uuid_guid_get_str(const unsigned char *guid_bin, char *guid_str) +const char *uuid_guid_get_str(const unsigned char *guid_bin) { int i; - *guid_str = 0; for (i = 0; i < ARRAY_SIZE(list_guid); i++) { if (!memcmp(list_guid[i].guid.b, guid_bin, 16)) { - strcpy(guid_str, list_guid[i].string); - return 0; + return list_guid[i].string; } } - return -ENODEV; + return NULL; } #endif |