diff options
| author | Andrew Scull | 2022-04-03 10:39:15 +0000 |
|---|---|---|
| committer | Tom Rini | 2022-04-29 11:11:36 -0400 |
| commit | d69616e529560ace8cdf40bda91464a88c7ff43a (patch) | |
| tree | f830de0295223e3d938244e60e80a89cdc7f3e91 /test | |
| parent | 7f58feae3fba07c349fe57e86ce8bd5cc2198f58 (diff) | |
test: dm: devres: Remove use-after-free
Use-after-free shouldn't be used, even in tests. It's bad practice and
makes the test brittle.
Signed-off-by: Andrew Scull <ascull@google.com>
Cc: Simon Glass <sjg@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'test')
| -rw-r--r-- | test/dm/devres.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/test/dm/devres.c b/test/dm/devres.c index 4f959d11da9..524114c833c 100644 --- a/test/dm/devres.c +++ b/test/dm/devres.c @@ -178,11 +178,8 @@ static int dm_test_devres_phase(struct unit_test_state *uts) ut_asserteq(1, stats.allocs); ut_asserteq(TEST_DEVRES_SIZE, stats.total_size); - /* Unbinding removes the other. Note this access a freed pointer */ + /* Unbinding removes the other. */ device_unbind(dev); - devres_get_stats(dev, &stats); - ut_asserteq(0, stats.allocs); - ut_asserteq(0, stats.total_size); return 0; } |