From 310ae37edb3becedf5da904201f3439ea42ab12f Mon Sep 17 00:00:00 2001
From: Thomas Huth
Date: Tue, 25 Aug 2015 17:09:40 +0200
Subject: Fix bad return value checks (detected with Coccinelle)

In the "Getting Started with Coccinelle - KVM edition" presentation that
has been held by Julia Lawall at the KVM forum 2015 (see the slides at
http://events.linuxfoundation.org/sites/events/files/slides/tutorial_kvm_0.pdf),
she pointed out some bad return value checks in U-Boot that can be
detected with Coccinelle by using the following config file:

@@
identifier x,y;
identifier f;
statement S;
@@
x = f(...);
(
 if (x < 0) S
|
 if (
-     y
+     x
 < 0) S
)

This patch now fixes these issues.

Signed-off-by: Thomas Huth <huth@tuxfamily.org>
---
 tools/fit_check_sign.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'tools/fit_check_sign.c')

diff --git a/tools/fit_check_sign.c b/tools/fit_check_sign.c
index 69e99c0d179..d9361b00950 100644
--- a/tools/fit_check_sign.c
+++ b/tools/fit_check_sign.c
@@ -75,7 +75,7 @@ int main(int argc, char **argv)
 	if (ffd < 0)
 		return EXIT_FAILURE;
 	kfd = mmap_fdt(cmdname, keyfile, 0, &key_blob, &ksbuf, false);
-	if (ffd < 0)
+	if (kfd < 0)
 		return EXIT_FAILURE;
 
 	image_set_host_blob(key_blob);
-- 
cgit v1.2.3