diff options
| author | Simon Glass | 2021-07-24 09:03:28 -0600 |
|---|---|---|
| committer | Tom Rini | 2021-08-02 13:31:32 -0400 |
| commit | 031725f8cdf33e836d19f35d3fe82c5baa5a2976 (patch) | |
| tree | 011d6f7d748bdc87fd5efcac5c8df758505cbc37 | |
| parent | 73994c452fc5a960114360a651201ac48b135e81 (diff) | |
hash: Ensure verification hex pairs are terminated
This function seems to assume that the chr[] variable contains zeros at
the start, which is not always true. Use strlcpy() to be safe.
Signed-off-by: Simon Glass <sjg@chromium.org>
| -rw-r--r-- | common/hash.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common/hash.c b/common/hash.c index 90cf46bcba5..059d381e231 100644 --- a/common/hash.c +++ b/common/hash.c @@ -396,7 +396,7 @@ int hash_parse_string(const char *algo_name, const char *str, uint8_t *result) for (i = 0; i < algo->digest_size; i++) { char chr[3]; - strncpy(chr, &str[i * 2], 2); + strlcpy(chr, &str[i * 2], 3); result[i] = simple_strtoul(chr, NULL, 16); } |