diff options
| author | Sean Anderson | 2020-09-14 11:02:00 -0400 |
|---|---|---|
| committer | Tom Rini | 2020-10-08 11:42:36 -0400 |
| commit | 18dbb7b335c2b4d14f2d72d77bdd60c6e5ebd25f (patch) | |
| tree | 12cc7bb5d2c6143b353385500b5671c9a5c2fcbb | |
| parent | af551daf9e0ab9c796015031beb02e5d62d29598 (diff) | |
gpio: dw: Add a trailing underscore to generated name
Previously, if there was no bank-name property, it was easy to have
confusing gpio names like "gpio1@08", instead of "gpio1@0_8". This patch
follows the example of the sifive gpio driver.
Signed-off-by: Sean Anderson <seanga2@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
| -rw-r--r-- | drivers/gpio/dwapb_gpio.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/drivers/gpio/dwapb_gpio.c b/drivers/gpio/dwapb_gpio.c index bf324f52394..a52c9e18e38 100644 --- a/drivers/gpio/dwapb_gpio.c +++ b/drivers/gpio/dwapb_gpio.c @@ -186,7 +186,15 @@ static int gpio_dwapb_bind(struct udevice *dev) * Fall back to node name. This means accessing pins * via bank name won't work. */ - plat->name = ofnode_get_name(node); + char name[32]; + + snprintf(name, sizeof(name), "%s_", + ofnode_get_name(node)); + plat->name = strdup(name); + if (!plat->name) { + kfree(plat); + return -ENOMEM; + } } ret = device_bind_ofnode(dev, dev->driver, plat->name, |