aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHanyuan Zhao2024-03-05 15:37:33 +0800
committerTom Rini2024-03-13 12:40:43 -0400
commit44951340309d0dca73c05fc61406a1e839d1da93 (patch)
tree16db46cea205f23cfbf2d0c125bf450f5c687ebb
parentefdf91c8eac143ff332c64ce58186f68ba396ae6 (diff)
cli: panic when failed to allocate memory for the history buffer
This commit simply modifies the history initialize function, replacing the return value by panic with reasons. The calling chains of hist_init don't have steps explicitly throwing or dealing with the ENOMEM error, and once the init fails, the whole system is died. Using panic here to provide error information instead. Signed-off-by: Hanyuan Zhao <hanyuan-z@qq.com>
-rw-r--r--common/cli_readline.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/common/cli_readline.c b/common/cli_readline.c
index 2507be22952..99e7efdfe55 100644
--- a/common/cli_readline.c
+++ b/common/cli_readline.c
@@ -110,7 +110,7 @@ static int hist_init(void)
hist = calloc(HIST_MAX, HIST_SIZE + 1);
if (!hist)
- return -ENOMEM;
+ panic("%s: calloc: out of memory!\n", __func__);
for (i = 0; i < HIST_MAX; i++)
hist_list[i] = hist + (i * (HIST_SIZE + 1));