aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlgapally Santosh Sagar2023-01-19 22:36:15 -0700
committerMichal Simek2023-01-27 08:42:47 +0100
commit508e1aa58c8f02a6b1a1013e3ff79d3e76015104 (patch)
treeffd3855edd30a10984bdb2bb60c921a11e3f9d78
parentfb737f1ed86c87a64e6626975cf51dd70a405cd2 (diff)
gpio: zynqmp: Handle error from get_gpio_modepin
There is a unused variable ret, due to which we are getting sparse warning as below. warning: variable 'ret' set but not used [-Wunused-but-set-variable]. Return ret incase of error. Signed-off-by: Algapally Santosh Sagar <santoshsagar.algapally@amd.com> Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@amd.com> Link: https://lore.kernel.org/r/20230120053617.32463-3-ashok.reddy.soma@amd.com Signed-off-by: Michal Simek <michal.simek@amd.com>
-rw-r--r--drivers/gpio/zynqmp_gpio_modepin.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/gpio/zynqmp_gpio_modepin.c b/drivers/gpio/zynqmp_gpio_modepin.c
index 078fd833959..e9565ff5430 100644
--- a/drivers/gpio/zynqmp_gpio_modepin.c
+++ b/drivers/gpio/zynqmp_gpio_modepin.c
@@ -48,6 +48,9 @@ static int modepin_gpio_set_value(struct udevice *dev, unsigned int offset,
int ret;
ret = get_gpio_modepin(ret_payload);
+ if (ret)
+ return ret;
+
if (value)
out_val = OUTVAL(offset) | ret_payload[1];
else