diff options
| author | Venkatesh Yadav Abbarapu | 2023-10-11 08:26:47 +0530 |
|---|---|---|
| committer | Michal Simek | 2023-11-07 13:47:08 +0100 |
| commit | ba9bdfd959f217a96772b83468c065b48f2581f0 (patch) | |
| tree | 27f5145e7b2342e3c5bc63ec5099840842d37303 | |
| parent | dea1c089cfee23e1dfd838e57aba050add2d3193 (diff) | |
drivers: firmware: Handle error case in the zynqmp_pm_feature
Unhandled error coming from xilinx_pm_request() but return
value is not read back that's why getting sparse warning
as below:
warning: variable 'ret' set but not used [-Wunused-but-set-variable].
In case of error return the "ret" value.
Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>
Link: https://lore.kernel.org/r/20231011025647.17200-1-venkatesh.abbarapu@amd.com
Signed-off-by: Michal Simek <michal.simek@amd.com>
| -rw-r--r-- | drivers/firmware/firmware-zynqmp.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/firmware/firmware-zynqmp.c b/drivers/firmware/firmware-zynqmp.c index 43fb7fa7787..8ea15c7ed33 100644 --- a/drivers/firmware/firmware-zynqmp.c +++ b/drivers/firmware/firmware-zynqmp.c @@ -203,6 +203,8 @@ int zynqmp_pm_feature(const u32 api_id) /* Check feature check API version */ ret = xilinx_pm_request(PM_FEATURE_CHECK, api_id, 0, 0, 0, ret_payload); + if (ret) + return ret; /* Return feature check version */ return ret_payload[1] & FIRMWARE_VERSION_MASK; |