diff options
| author | Marek Vasut | 2022-04-22 15:15:54 +0200 |
|---|---|---|
| committer | Tom Rini | 2022-04-28 09:26:43 -0400 |
| commit | c438866b16745fc69f0f05636b9cf69b16378fca (patch) | |
| tree | 265b17bad014b6c6e59187e0c465c5ccbf8dd169 | |
| parent | 9cc32bfa49d23a4d1bed9e6119255f2e78e20232 (diff) | |
led: Mark device instance with DM_FLAG_PROBE_AFTER_BIND
Calling device_probe() from uclass .post_bind() callback has all kinds
of odd side-effects, e.g. device instances not being available just yet.
Make use of the DM_FLAG_PROBE_AFTER_BIND instead, mark device instances
which need to be probe()d in order to configure the LED default state
with this flag and let the DM core do the device_probe() at the right
time instead.
Fixes: 72675b063b6 ("led: Configure LED default-state on boot")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
Cc: Sean Anderson <seanga2@gmail.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Steven Lawrance <steven.lawrance@softathome.com>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Tested-by: Patrice Chotard <patrice.chotard@foss.st.com>
| -rw-r--r-- | drivers/led/led-uclass.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/led/led-uclass.c b/drivers/led/led-uclass.c index 5d7bf40896b..2ce72933b6c 100644 --- a/drivers/led/led-uclass.c +++ b/drivers/led/led-uclass.c @@ -98,7 +98,9 @@ static int led_post_bind(struct udevice *dev) * In case the LED has default-state DT property, trigger * probe() to configure its default state during startup. */ - return device_probe(dev); + dev_or_flags(dev, DM_FLAG_PROBE_AFTER_BIND); + + return 0; } static int led_post_probe(struct udevice *dev) |