diff options
| author | Mike Frysinger | 2008-10-14 07:04:38 -0400 |
|---|---|---|
| committer | Wolfgang Denk | 2008-10-14 14:19:34 +0200 |
| commit | c46980f6d2135ade345dadc1fb1f1f4c8bbf255a (patch) | |
| tree | 0d04458ec6dba12a7de97e631deb1c0bee3845f1 | |
| parent | d5fd0b49210c941de8a1fce3947ace92243ab5ca (diff) | |
cmd_spi: remove broken signed casting for display
Since we're working with unsigned data, you can't apply a signed pointer
cast and then attempt to print the result. Otherwise you get wrong output
when the sign bit is set like "0xFF" incorrectly extended to "0xFFFFFFFF".
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
| -rw-r--r-- | common/cmd_spi.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/common/cmd_spi.c b/common/cmd_spi.c index 40ee7e7dd3c..1f0727b4a24 100644 --- a/common/cmd_spi.c +++ b/common/cmd_spi.c @@ -123,9 +123,8 @@ int do_spi (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) printf("Error with the SPI transaction.\n"); rcode = 1; } else { - cp = (char *)din; for(j = 0; j < ((bitlen + 7) / 8); j++) { - printf("%02X", *cp++); + printf("%02X", din[j]); } printf("\n"); } |