diff options
| author | Vladimir Oltean | 2021-09-27 14:21:42 +0300 |
|---|---|---|
| committer | Ramon Fried | 2021-09-28 18:50:56 +0300 |
| commit | 61efbece570af3fe0881fc59dba06ede15eb8a6f (patch) | |
| tree | 03a2014d55f8c2fea5eb76ff0a36943407e6aa34 /board/gdsys | |
| parent | fca315a38202960cfbb4c5a8f3ff5e0860e630cb (diff) | |
board: gdsys: a38x: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation
strncpy() simply bails out when copying a source string whose size
exceeds the destination string size, potentially leaving the destination
string unterminated.
One possible way to address is to pass MDIO_NAME_LEN - 1 and a
previously zero-initialized destination string, but this is more
difficult to maintain.
The chosen alternative is to use strlcpy(), which properly limits the
copy len in the (srclen >= size) case to "size - 1", and which is also
more efficient than the strncpy() byte-by-byte implementation by using
memcpy. The destination string returned by strlcpy() is always NULL
terminated.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Diffstat (limited to 'board/gdsys')
| -rw-r--r-- | board/gdsys/a38x/ihs_phys.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/board/gdsys/a38x/ihs_phys.c b/board/gdsys/a38x/ihs_phys.c index c23d1509214..e09c0006b76 100644 --- a/board/gdsys/a38x/ihs_phys.c +++ b/board/gdsys/a38x/ihs_phys.c @@ -110,9 +110,7 @@ int register_miiphy_bus(uint k, struct mii_dev **bus) if (!mdiodev) return -ENOMEM; - strncpy(mdiodev->name, - name, - MDIO_NAME_LEN); + strlcpy(mdiodev->name, name, MDIO_NAME_LEN); mdiodev->read = bb_miiphy_read; mdiodev->write = bb_miiphy_write; |