aboutsummaryrefslogtreecommitdiff
path: root/cmd/flash.c
diff options
context:
space:
mode:
authorVladimir Oltean2021-09-27 14:21:48 +0300
committerRamon Fried2021-09-28 18:50:56 +0300
commitf848b4804e99bbbeaa46934589d77a2403108e66 (patch)
tree79bc83749d471927423bda9b44b7d434804482d3 /cmd/flash.c
parent9be5fa4d5766cb18e533ac6754879847d1e7a9ea (diff)
net: enetc: ensure imdio.name is NULL terminated after MDIO_NAME_LEN truncation
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more difficult to maintain. The chosen alternative is to use strlcpy(), which properly limits the copy len in the (srclen >= size) case to "size - 1", and which is also more efficient than the strncpy() byte-by-byte implementation by using memcpy. The destination string returned by strlcpy() is always NULL terminated. Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Diffstat (limited to 'cmd/flash.c')
0 files changed, 0 insertions, 0 deletions