diff options
author | Vladimir Oltean | 2021-09-27 14:21:47 +0300 |
---|---|---|
committer | Ramon Fried | 2021-09-28 18:50:56 +0300 |
commit | 9be5fa4d5766cb18e533ac6754879847d1e7a9ea (patch) | |
tree | 0f70ae589bb51f91d2c2926341924a999a8add30 /cmd/ini.c | |
parent | e7444a199a61ffcd605c9c51c9ec32d89be696b1 (diff) |
net: ep93xx: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation
strncpy() simply bails out when copying a source string whose size
exceeds the destination string size, potentially leaving the destination
string unterminated.
One possible way to address is to pass MDIO_NAME_LEN - 1 and a
previously zero-initialized destination string, but this is more
difficult to maintain.
The chosen alternative is to use strlcpy(), which properly limits the
copy len in the (srclen >= size) case to "size - 1", and which is also
more efficient than the strncpy() byte-by-byte implementation by using
memcpy. The destination string returned by strlcpy() is always NULL
terminated.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Diffstat (limited to 'cmd/ini.c')
0 files changed, 0 insertions, 0 deletions